Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong clang-format requirement #995

Closed
SaschaWillems opened this issue Mar 21, 2024 · 0 comments · Fixed by #1048
Closed

Wrong clang-format requirement #995

SaschaWillems opened this issue Mar 21, 2024 · 0 comments · Fixed by #1048
Assignees
@SaschaWillems
Labels
documentation Improvements or additions to documentation

Comments

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Mar 21, 2024 •
edited

In our documentation we still state that clang-format 8 is recommended:

Vulkan-Samples/CONTRIBUTING.adoc

Line 148 in 9ad2c09

Ensure that you are using clang-format 8.

In other places we state that we support clang-format-9 and up but afaik we recommend (or require) clang-format 15.

We should check our build documentation and make sure it's up-to-date or else it'll confuse people.
@SaschaWillems SaschaWillems added the documentation Improvements or additions to documentation label Mar 21, 2024
@SaschaWillems SaschaWillems mentioned this issue May 18, 2024
Merged
13 tasks
@SaschaWillems SaschaWillems self-assigned this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaschaWillems SaschaWillems

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update clang-format requirements in documentation SaschaWillems/Vulkan-Samples
1 participant
@SaschaWillems