Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean typing removed while reading data #62

Open
dipasqualew opened this issue Jan 20, 2021 · 0 comments
Open

Boolean typing removed while reading data #62

dipasqualew opened this issue Jan 20, 2021 · 0 comments

Comments

@dipasqualew
Copy link

Hi, I wanted to thank for your work. Querying Athena from JS can be cumbersome and your library really helps.

We have encountered an issue with parsing results from Athena queries. In particular, if a Glue column is marked as boolean, the information is lost in translation when parsing the .csv results file.

Typing information is stored in a nearby .csv.metadata file, see:
https://docs.aws.amazon.com/athena/latest/ug/querying.html

I don't think the library is parsing any of the typings when reading the results from the CSV, which is mostly ok in JS. Strings are still strings, numbers are properly casted. But Boolean("false") === true and this behaviour can cause very hard-to-track bugs (like the one that lead me here).

I am opening the issue in case you are not aware of the issue.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant