Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-science-stack.Dockerfile should use data-science-stack #99

Open
mattf opened this issue Mar 19, 2021 · 0 comments
Open

data-science-stack.Dockerfile should use data-science-stack #99

mattf opened this issue Mar 19, 2021 · 0 comments

Comments

@mattf
Copy link
Contributor

mattf commented Mar 19, 2021

RUN curl https://repo.anaconda.com/miniconda/Miniconda3-py37_${CONDA_VERSION}-Linux-x86_64.sh -k -o /miniconda.sh \
&& sh /miniconda.sh -b -p ${CONDA_ROOT} \
&& rm -f /miniconda.sh \
&& echo "conda ${CONDA_VERSION}" >> /conda/conda-meta/pinned \
&& ${CONDA_ROOT}/bin/conda init bash \
&& echo "#!/bin/bash\n\
source /conda/bin/activate data-science-stack-${STACK_VERSION}\n\
jupyter-lab --allow-root --ip=0.0.0.0 --no-browser --NotebookApp.token='' --notebook-dir=${NOTEBOOKS_DIR}" > /run-jupyter \
&& chmod 755 /run-jupyter \
&& mkdir -p ${NOTEBOOKS_DIR} \
&& cd ${NOTEBOOKS_DIR} \
&& git clone --single-branch --depth 1 --branch branch-${RAPIDS_VERSION} \
https://github.com/rapidsai/notebooks.git \
&& cd notebooks \
&& git submodule update --init --remote \
&& rm -rf .git \
&& rm -rf `find repos/ -maxdepth 2 -mindepth 2 | grep -v notebooks`

these lines can be replaced by a RUN data-science-stack install install-miniconda and install-notebooks

this will reduce code duplication and the number of places versions need to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant