Switch to high-quality assets #277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike other assets, the application icon only gets loaded once. By using the SVG, we can ensure the image is always sized appropriately (and is suitably crisp) on all screens. Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
CMake copies the original file permissions during the templating process; by marking runwrapper.sh.in executable (ok, it isn't really), we end up with build/runwrapper.sh being marked executable as well. Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
Output was additionally run through pngcrush to ensure optimized file sizes. Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
Re-export at 64x64 and pngcrush. Additionally, convert from an older Inkscape SVG to SVG v1.1 format. This includes the following icons: - benchmark from edit-paste, - edit-undo, - edit-redo, - group from folder, - value from text-x-generic, - rule from preferences-system Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
Started with Tango's x-office-spreadsheet, removed the database icon, and added in the selection effect from the original Profile icon. This remains faithful to the intent of the original icon while using known-good assets from the Tango project as the base (and providing a SVG as well for the future). Resolves: OpenSCAP#275 Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
This should enable SCAP Workbench to perform a little better when operating on hi-dpi displays. See also: https://doc.qt.io/qt-5/highdpi.html Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
|
Interesting; this doesn't actually appear to resolve the issues on my laptop. |
|
The PR would probably benefit from a rebase, as it fails to compile on F34 for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import SVGs from Tango project and re-export existing icons at 64x64 size. This should ensure they're sufficiently large for all display purposes.
Also included are three code changes:
runwrapper.sh.inexecutable, makingbuild/runwrapper.shexecutable as well.AA_EnableHighDpiScaling; see https://doc.qt.io/qt-5/highdpi.html.Resolves: #275