Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying feedback session: Name for copied session should not be whitespace #12679

Open
domlimm opened this issue Dec 24, 2023 · 36 comments · May be fixed by #13075
Open

Copying feedback session: Name for copied session should not be whitespace #12679

domlimm opened this issue Dec 24, 2023 · 36 comments · May be fixed by #13075
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors

Comments

@domlimm
Copy link
Contributor

domlimm commented Dec 24, 2023

Steps to reproduce

  1. Head to Sessions page.
  2. On any course, click on Copy.
  3. You should see this that the Name for copied session* has the same name as the Session you clicked Copy on. Now, clear the text input and this is what you will get below.
    image

Now, let's try to add a whitespace. Validation passes i.e., There is a value for the copied session's name and it is a whitespace.

image

Expected behaviour

Whitespace should not be allowed for the copied session's name. Input validation should not allow whitespaces.

Actual behaviour

Converse of the above expected behaviour, i.e., Currently, whitespace as name is allowed and this happens after clicking on Copy:
image

This is validated on the client side. However, we should validate on the form first.

Additional info

Motivation for this issue from a PR: #12670 (comment)

Proposed Solution:

  1. You may look at this link on form validation: https://www.javatpoint.com/angular-form-validation-no-whitespace-allowed
  2. Refer to this file in the codebase: src\web\app\pages-help\session-links-recovery\session-links-recovery-page.component.ts, there is an example on how validation is done L39, and you may use the above link in Point 1 to help you too.
    And this is the page (http://localhost:4200/web/front/help/session-links-recovery):
    image
    To get to the above page, once you're logged in, in the navbar, click on Help -> Recover Session Links -> Hit on Submit without any input.

Let us know if you have any question.
@domlimm domlimm added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors labels Dec 24, 2023
@github-actions GitHub Actions
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

@dhanushtheijas08
Copy link

I would like to work on this issue. Can i go ahead?

@domlimm
Copy link
Contributor Author

domlimm commented Dec 24, 2023

@dhanushtheijas08 Sure thing. Feel free to submit a PR for this issue 👍🏻

@rahulpro2001
Copy link

@domlimm Hi , I am beginner,
could I contribute for this issue?

@domlimm
Copy link
Contributor Author

domlimm commented Dec 25, 2023

@rahulpro2001 Hello, please allow @dhanushtheijas08 to work on it first as he has expressed in interest. Feel free to look at other issues tagged with good first issue for the time being!

@rahulpro2001
Copy link

@domlimm okk

@ArunErram
Copy link

ArunErram commented Dec 27, 2023 •
edited

can i work on these issue please, these is my first open source contribution !

@pavanganguru
Copy link

Hi Could any one help me setting up project in my local system, I am getting error at build.properties as null pointer exception. Thanks

@cedricongjh
Copy link
Contributor

can i work on these issue please, these is my first open source contribution !

hi @ArunErram please allow @dhanushtheijas08 to work on it first as he has expressed interest for this issue

@cedricongjh
Copy link
Contributor

hi @pavanganguru, do open a help request here: https://github.com/TEAMMATES/teammates/discussions, it would be good to provide screenshots or more details about the error you're facing as well

@IvoHarsani
Copy link

I see that this issue is still open, can I work on it? Also, how can I become a contributor for this repo?

@michaelviveiros
Copy link

Posso contribuir com a issue ?

@SArora12
Copy link
Contributor

SArora12 commented Jan 9, 2024

Hey! is the issue resolved? If it is still open , i would like to contribute to this issue! Please let me know if I can

@domlimm
Copy link
Contributor Author

domlimm commented Jan 13, 2024

@dhanushtheijas08 Hello, is there any update on this issue? Else, I will ping the next person to attempt it. Thanks!

@Afreen97
Copy link

Hey.I still see this issue open and showing not resolved in my local.Can I take it up?

@domlimm
Copy link
Contributor Author

domlimm commented Jan 17, 2024

@rahulpro2001 Please feel free to submit a PR for this if you're still interested. Else, I will pass it onto the next person. Thank you!

@Afreen97 Let's go down the queue. Feel free to look at other issues tagged good first issue for the time being!

@sanjai0py
Copy link

hey @domlimm, i'm also interested in working on this. please add me to the queue.

@domlimm
Copy link
Contributor Author

domlimm commented Jan 20, 2024

@ArunErram @IvoHarsani @michaelviveiros Do let me know if any of you wants to take up this issue.

@michaelviveiros
Copy link

@ArunErram @IvoHarsani @michaelviveiros Do let me know if any of you wants to take up this issue.

@domlimm If it's available I would like it.

@domlimm
Copy link
Contributor Author

domlimm commented Jan 20, 2024

@michaelviveiros Hey Michael, feel free to submit a PR for it! Thanks!

@ritsam
Copy link

ritsam commented Jan 24, 2024

Hello I am a beginner and would like to work on this issue.

@domlimm
Copy link
Contributor Author

domlimm commented Jan 24, 2024

@ritsam Hello, lets give @michaelviveiros some time to work on this. Michael do let us know if you're not working on it anymore.

@ritsam in the meantime, you may look for other good first issue to work on.

@ArunErram
Copy link

i think, i missed the oppurtunity , do i have the chance now to work on it @domlimm ?

@cedricongjh
Copy link
Contributor

hi @michaelviveiros, do let us know within 2 days if you're still working on this issue, else we'll let @ArunErram work on it

@ArunErram
Copy link

ya @michaelviveiros update please ASAP , Thanks !

@weiquu
Copy link
Contributor

weiquu commented Jan 30, 2024

Hi @ArunErram, since @michaelviveiros hasn't replied, please feel free to submit a PR for this issue. Thanks for your patience!

@ArunErram
Copy link

@weiquu sure i'm on it

@ArunErram
Copy link

ArunErram commented Jan 31, 2024 •
edited

@weiquu @domlimm i have started working on it . But while i am trying to login as student or instructor the login page is not getting displayed .
loginsnap

@ArunErram
Copy link

ArunErram commented Jan 31, 2024 •
edited

and from where can i get the test credentials to login and test the expected behaviour after making the changes?

@cedricongjh
Copy link
Contributor

and from where can i get the test credentials to login and test the expected behaviour after making the changes?

Hi @ArunErram, do refer to https://teammates.github.io/teammates/development.html#logging-in-to-a-teammates-instance for logging in to the local dev environment

@ArunErram
Copy link

ok i'll work on it , thanks

@ArunErram
Copy link

@cedricongjh after clicking on the login as instructor or student , it's not rendering to login page it's still being on the home page after loading. can you help me with these please

@ArunErram
Copy link

i have added the validations for whitespace and the rest is to just test it

@weiquu
Copy link
Contributor

weiquu commented Feb 5, 2024

Hi @ArunErram, please open a new topic under Discussions if you are facing any trouble that is not directly related to the current issue being fixed. In the meantime, you can also open a draft PR and tag us there if you want us to take a preliminary look

ArunErram added a commit to ArunErram/teammates that referenced this issue Feb 6, 2024
@ArunErram
Added whitespace validation TEAMMATES#12679
2b1acc9
ArunErram added a commit to ArunErram/teammates that referenced this issue Feb 6, 2024
@ArunErram
Added validation of Whitespace(TEAMMATES#12679) in copySessionModel
8947e1d
@ArunErram ArunErram mentioned this issue Feb 6, 2024
Closed
@rapiddeveloper22
Copy link

Hi can I work on this issue as this is still open?

@ArunErram
Copy link

@domlimm any updates please ?

@ArunErram ArunErram mentioned this issue Apr 21, 2024
Closed
@Josephine0110 Josephine0110 linked a pull request Apr 21, 2024 that will close this issue
Open
ArunErram added a commit to ArunErram/teammates that referenced this issue Apr 27, 2024
@ArunErram
[TEAMMATES#12679]Name for copied session should not be whitespace
5aafee4
ArunErram added a commit to ArunErram/teammates that referenced this issue Apr 27, 2024
@ArunErram
[TEAMMATES#12679] New Branch
250febc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors
Projects
None yet
Milestone
No milestone