Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TABL - "Delete and recreate local object" will lead to data loss #6746

Open
larshp opened this issue Jan 10, 2024 · 2 comments
Open

TABL - "Delete and recreate local object" will lead to data loss #6746

larshp opened this issue Jan 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@larshp
Copy link
Member

larshp commented Jan 10, 2024

When pulling a transparent TABL, abapGit determined to "Delete and recreate local object", which will lead to data loss. The table exists locally and remotely.

As usual, the status information is wrong, there is not enough information in abapGit to determine if "added locally or deleted remotely"

we need to remove/revamp the status functionality so its correct in all cases

the possible cases are:
a. exists locally only
b. exists remotely only
c. exits in both, differences
d. exists in both, identical

might also be in connection with a package move

image

@larshp larshp added the bug Something isn't working label Jan 10, 2024
@mbtools
Copy link
Member

mbtools commented Jan 10, 2024

Options:

  1. enhance checksums to work by branch/tag/remote
  2. remove checksum feature completely (it's not needed for the listed cases)

Without checksums, we won't be able to tell which side was changed. So "add" or "delete" status won't be possible, which has implications to pull and stage dialogs. Also "diff" colors (green vs red) are not clearly defined.

However, I don't see how checksums are related to the "TABL re-create" problem. If abapGit actually showed "Delete and recreate local object" then it's a UI issue to present this more clearly as a warning that might require extra confirmation.

@larshp
Copy link
Member Author

larshp commented Jan 18, 2024

when manually moving local object to the right package, the status changes to "Overwrite local object" instead of "Delete and recreate local object"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants