Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure Package type not taken from Git repository in nested package setup during Pull #6923

Open
eoud opened this issue May 8, 2024 · 6 comments
Labels
bug Something isn't working serialization Translate between object types and files

Comments

@eoud
Copy link

eoud commented May 8, 2024

Good day,

When my original nested package setup is:

  • ZDEV (Structure Package)
    -- ZBC (Structure Package)
    -- -- ZBC_ABA (Structure Package)
    -- -- -- ZBC_ABA_ATF (Development Package)

All packages in the GitHub repository will reflect the correct types after staging, and I create the ZDEV package manually in the target system. So far so good.

However, when pulling the repository (Folder Logic = Full) in a new system the following error is given:
image

Besides that the error message (import of object...failed) is incorrect, since the package actually are imported, they are imported as type Development Packages, thus ignoring the source XML values for:
<RESTRICTED>X</RESTRICTED>
<MAINPACK>S</MAINPACK>

In the target system this then results in:

  • ZDEV (Structure Package)(as manually created beforehand)
    -- ZBC (Development Package)
    -- -- ZBC_ABA (Development Package)
    -- -- -- ZBC_ABA_ATF (Development Package)

For both the stage and pull I've used the standalone version: abapmerge 0.16.0 - 2024-04-24T14:41:46.792Z and both SAP systems are S4H op2023.

@larshp
Copy link
Member

larshp commented May 8, 2024

when manually creating ZDEV, did you create it as a structure package?

@eoud
Copy link
Author

eoud commented May 8, 2024

Yes sir :-)

@eoud
Copy link
Author

eoud commented May 8, 2024

I've added you as a collaborator to the repository on GitHub, perhaps that will make it a bit easier for you

@larshp
Copy link
Member

larshp commented May 8, 2024

yea, well, we'd like a public accessible example, ideally in https://github.com/abapgit-tests

there is already https://github.com/abapGit-tests/DEVC_struct_package , not sure if it has broken, or there is another scenario

anyhow, I dont have time to look into it today(somebody else feel free to pick it up)

@eoud
Copy link
Author

eoud commented May 8, 2024

I've created a public repo https://github.com/eoud/DEVC_Nested_Struc_6923.git. There is no rush for it today, but if someone has time at some point it would be great. Thanks in advance.

@mbtools mbtools added the serialization Translate between object types and files label May 11, 2024
@mbtools
Copy link
Member

mbtools commented May 28, 2024

I was able to reproduce it.

abapGit automatically creates all packages as (template) development packages as a first step.

Then the packages (and other objects) are deserialized. However, in this case, the packages are processed in the wrong order:

image

In my case, the repo package ZTEST should be deserialized first. This would change it to a structure package. Then ZBC could be changed as well. And so on.

We do have method get_deserialize_order but it's not fully implemented yet, unfortunately. It's not trivial... I don't think I have time for it before July.

@mbtools mbtools added the bug Something isn't working label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working serialization Translate between object types and files
Development

No branches or pull requests

3 participants