Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (58ce54c) to head (6eb2d10).
Report is 3 commits behind head on master.

@@           Coverage Diff           @@
##           master    #8338   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         140      140           
  Lines        4018     4018           
=======================================
  Hits         3982     3982           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I'm fine with either. Is the aria-label the recommended approach? If so, then we should use that.

That's a good question. I'm not sure

1. Bootstrap uses aria-label for its main navigation button
2. Tailwind uses aria-labelledby with references to a visually hidden label near the button
3. One of the first google results is https://gomakethings.com/revisting-aria-label-versus-a-visually-hidden-class/ (which is 4 year old), and it suggest to use sr-only

If we label these buttons, wouldn't we need to label others like the main navigation?

That's correct. Since that button is not visible in large desktop, it was not spotted by lighthouse

The upgrading guide should also be updated to include the new locale keys.

Will do that