Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs NeutralColorPalette section has wrong hint. #48970

Closed
Mingeax opened this issue May 18, 2024 · 1 comment · Fixed by #48973
Closed

Docs NeutralColorPalette section has wrong hint. #48970

Mingeax opened this issue May 18, 2024 · 1 comment · Fixed by #48973
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@Mingeax
Copy link

Mingeax commented May 18, 2024

Reproduction link

https://ant-design.antgroup.com/docs/spec/colors#palette-generation-tool

Steps to reproduce

Select a main color with low saturation and lightness. A hint will warn. But the Brightness value is wrong.

What is expected?

The Brightness value is wrong.

What is actually happening?

The Brightness value is correct.

Environment Info
antd 5.17.2
React 18
System windows10
Browser edge

File '.dumi/theme/common/Color/ColorPaletteTool.tsx' line 44 write text = locale.brightness((s * 100).toFixed(2));, I think it's why that hint is wrong. See '

text += locale.brightness((s * 100).toFixed(2));
'

@afc163 afc163 added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 🐛 Bug Ant Design Team had proved that this is a bug. and removed unconfirmed labels May 18, 2024
Copy link
Contributor

Hello @Mingeax. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @Mingeax,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants