[ISSUE#8142] Show time of create topic and subScriptionGroup #8143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8143 +/- ##
=============================================
- Coverage 42.95% 42.85% -0.11%
+ Complexity 10384 10355 -29
=============================================
Files 1270 1270
Lines 88690 88696 +6
Branches 11401 11402 +1
=============================================
- Hits 38097 38010 -87
- Misses 45899 45978 +79
- Partials 4694 4708 +14 ☔ View full report in Codecov by Sentry. |
guyinyou
reviewed
May 15, 2024
| @@ -1462,6 +1468,10 @@ private RemotingCommand updateAndCreateSubscriptionGroup(ChannelHandlerContext c | |||
|
|
|||
| response.setCode(ResponseCode.SUCCESS); | |||
| response.setRemark(null); | |||
| long endTime = System.currentTimeMillis(); | |||
| long executionTime = endTime - startTime; | |||
| LOGGER.info("" + config.getGroupName() + " is " + executionTime + "ms"); | |||
humkum
suggested changes
May 15, 2024
| @@ -67,6 +67,7 @@ public void dispatch(DispatchRequest request) { | |||
| while (iterator.hasNext()) { | |||
| ConsumerFilterData filterData = iterator.next(); | |||
|
|
|||
|
|
|||
| long endTime = System.currentTimeMillis(); | ||
| long executionTime = endTime - startTime; | ||
| LOGGER.info("" + config.getGroupName() + " is " + executionTime + "ms"); | ||
| LOGGER.info("" + config.getGroupName() + " is " + executionTime + "ms"); |
RongtongJin
reviewed
May 16, 2024
Comment on lines
519
to
521
| long endTime = System.currentTimeMillis(); | ||
| long executionTime = endTime - startTime; | ||
| LOGGER.info("executionTime of create topic:" + topic + " is " + executionTime + "ms"); |
There was a problem hiding this comment.
Could you simplify the code？
RongtongJin
approved these changes
May 16, 2024
|
ping @humkum Do you have any more suggestions？ |
Willhow-Gao
approved these changes
May 16, 2024
cserwen
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execution time of create topic and subscription
Fixes #8142
show time of create topic and subScriptionGroup
add logs of execution time of create topic and subscription