Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any security guarantee? #276

Open
fchabouis opened this issue Oct 18, 2023 · 4 comments
Open

Any security guarantee? #276

fchabouis opened this issue Oct 18, 2023 · 4 comments
Labels
question Further information is requested

Comments

@fchabouis
Copy link

Hi,
I have tested the tool and it is working fine.
I am wondering if there is an guarantee that my credentials won't be leaked. Of course keys are stored as Github secrets, but your code has access to the secrets and could possibly log them somewhere. I am probably not the first one with this concern, but I didn't find any information about such a risk.
Thanks!

@xxfogs
Copy link

xxfogs commented Oct 19, 2023

Same question, are there any guarantees preventing potential unauthorized modifications being made to this repository?

@bugohoss12
Copy link

bugohoss12 commented Oct 26, 2023

Asked myself the same question recently. One option to mitigate the risk is, switching to self-hosted runners from Github. Setup an SSH-Key on your self hosted runner and add it to the known_hosts on your server. Hereby you can avoid storing the private-key outside of the machine. See https://stackoverflow.com/a/72983036 .

@appleboy
Copy link
Owner

@appleboy appleboy added the question Further information is requested label Oct 26, 2023
@appleboy
Copy link
Owner

build docker image from here:

FROM ghcr.io/appleboy/drone-ssh:1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants