Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache templates data to improve performance #33440

Closed
AnaghHegde opened this issue May 14, 2024 · 0 comments · Fixed by #33439
Closed

Cache templates data to improve performance #33440

AnaghHegde opened this issue May 14, 2024 · 0 comments · Fixed by #33439
Assignees
Labels
Enhancement New feature or request QA Pod Issues under the QA Pod QA Needs QA attention Templates Pod Issues related to Templates Templates Issues related to templates

Comments

@AnaghHegde
Copy link
Member

No description provided.

@AnaghHegde AnaghHegde added Enhancement New feature or request Templates Issues related to templates Templates Pod Issues related to Templates labels May 14, 2024
@AnaghHegde AnaghHegde self-assigned this May 14, 2024
rahulbarwal pushed a commit that referenced this issue Jun 5, 2024
## Description
Cache the templates data to improve the turn around time


Fixes #33440

## Automation

/ok-to-test tags="@tag.Templates"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9368135903>
> Commit: 5cbcbd3
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9368135903&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced caching functionality for application templates and data to
improve performance.

- **Bug Fixes**
- Updated error handling for cloud services errors, changing the HTTP
status code from 500 to 400.

- **Tests**
- Added test cases to ensure data retrieval accuracy and validate cache
utilization for application templates.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Jun 5, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request QA Pod Issues under the QA Pod QA Needs QA attention Templates Pod Issues related to Templates Templates Issues related to templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants