Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sync waves for applicationset #18268

Open
Emmerson-Miranda opened this issue May 17, 2024 · 2 comments
Open

Support sync waves for applicationset #18268

Emmerson-Miranda opened this issue May 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Emmerson-Miranda
Copy link

Summary

ApplicationSets generate argo applications, sometimes we have dependencies in the order to deploy the applications, for instance istio need cert-manager to be up and running first.

Motivation

Sometimes we have dependencies in the order to deploy the applications, for instance istio needs cert-manager to be up and running first. I another cases we depends in CRDs deployed by other apps.

I created a bug ticket and I was suggested to open an enhancement proposal here #17639

Proposal

We need to be able to generate argo applications with applicationset, inside each application we should be able to use the sync wave annotation.

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: cert-manager
  namespace: argocd
  metadata:
    annotations:
      argocd.argoproj.io/sync-wave: "-10"

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: istio
  namespace: argocd
  metadata:
    annotations:
      argocd.argoproj.io/sync-wave: "-9"
@Emmerson-Miranda Emmerson-Miranda added the enhancement New feature or request label May 17, 2024
@ChristianCiach
Copy link
Contributor

Isn't this what Progressive Syncs are for?

Also, there seems to be ongoing work for supporting explicit application dependencies:

@Emmerson-Miranda
Copy link
Author

Emmerson-Miranda commented May 17, 2024

Thanks @ChristianCiach

Is not what progressive syncs solves. I am not even reconsidering this because is Alpha.

Is the same case as Application dependencies you mentioned. I also fixed implementing app-of-apps but it should be nice if Argo applicationset can support waves to deploy dependent apps in certain order OOTB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants