Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource identifier should be placed as a path parameter #25

Open
wypiorsebastian opened this issue May 18, 2021 · 2 comments
Open

Resource identifier should be placed as a path parameter #25

wypiorsebastian opened this issue May 18, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@wypiorsebastian
Copy link

I know it's not a course about RESTful principles but maybe you'll consider in the future extracting resource id from request body to path parameter ?

run-aspnetcore-microservices/src/Services/Catalog/Catalog.API/Controllers/CatalogController.cs

Line 85 in c30712a

public async Task<IActionResult> UpdateProduct([FromBody] Product product)

@mehmetozkaya
Copy link
Member

yes you exactly right, this is good to fix in this issue. I will check it later thanks.

@mehmetozkaya mehmetozkaya added the good first issue Good for newcomers label May 20, 2021
@wypiorsebastian
Copy link
Author

No problem. Glad I could help. BTW - great course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mehmetozkaya @wypiorsebastian