Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-standalone actions should not be able to run with no records if on index_controls #2735

Open
JeremasPosta opened this issue May 1, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working Help wanted We could use some help with this Javascript Pull requests that update Javascript code

Comments

@JeremasPosta
Copy link
Contributor

Feature

Non-standalone actions should not be able to run with no records if on index_controls
From Discord:

When actions are listed on the dropdown, they are disabled/greyed if the action isn't standalone AND if we have not selected records from the checkboxes. Awesome, all good, prevent us from running the action with no records selected.

Is it possible to replicate this feature somehow when we copy the actions directly into the index_controls?
It is a bad UX to the action needed to load and run, to then, display them a No records selected error.
Without mentioning they will need to write/select/whatever from the action-fields again.

Current workarounds

N/a

Screenshots or screen recordings

N/a

Additional context

N/a

Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label May 17, 2024
@Paul-Bob Paul-Bob removed the Stale label May 17, 2024
@adrianthedev adrianthedev added the Bug Something isn't working label May 28, 2024
@adrianthedev
Copy link
Collaborator

The bug consists in not having the action disabled if it's not standalone and is added to the index_controls

self.index_controls do
  action SOME_ACTION # this will be enabled even when no records are selected and it should be disabled
end

def actions
  action SOME_ACTION # this would be disabled in the begining in the actions_list dropdown because it's not standalone and no records would be selected
end

@adrianthedev adrianthedev added Help wanted We could use some help with this Javascript Pull requests that update Javascript code labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Help wanted We could use some help with this Javascript Pull requests that update Javascript code
Projects
Status: To Do
Development

No branches or pull requests

4 participants