Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Support for multiple jobs for a service type? #29

Open
taschmidt opened this issue Jul 2, 2021 · 1 comment
Open

Support for multiple jobs for a service type? #29

taschmidt opened this issue Jul 2, 2021 · 1 comment

Comments

@taschmidt
Copy link

We have multiple CloudFront distributions (across a couple different AWS accounts). It seems like the job definition file only allows a single job per service type. It seems like allowing the job definition file to be overridden could help both those situations.

Like maybe changing this line https://github.com/awslabs/athena-glue-service-logs/blob/master/Makefile#L6 to:
JOB_DEFINITION_FILE?=scripts/glue_jobs.json ?

@dacort
Copy link
Contributor

dacort commented Jul 2, 2021

Hey @taschmidt

You've got a good point here - easiest thing is probably just adding a line as you mentioned, but in reality the glue_jobs.json file should probably just be a list of job definitions rather than a dictionary with the key being hard-coded to the service type.

I've been experimenting with Glue blueprints as a replacement for big chunks of this script so will take that into consideration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants