Bulk adding jobs to a batch - how to combine bulk and batch?

[amo13]

I have a potentially large amount of jobs that I want to enqueue and run in a batch. I also read about the bulk enqueuing functionality and thought, I'd combine them:

update_batch = GoodJob::Batch.new(on_finish: MyCallbackJob) do
  GoodJob::Bulk.enqueue do
    [lots_of_things_needing_update].each do |thing|
      MyUpdateJob.perform_later(thing: thing, target_version: "1.2.3")
    end
  end
end
update_batch.description = "Update all things to 1.2.3"
update_batch.save
update_batch.enqueue

But somehow, the batch ends up being empty. How do I combine those to enqueue all jobs in a batch and also optimize the query to the database?

[bensheldon]

A Batch already Bulk enqueues.

GoodJob::Batch uses it's own bulking wrapper (a GoodJob::Bulk::Buffer, which is the lower-level object also used by GoodJob::Bulk) to capture jobs, so creating a new GoodJob::Bulk will intercept those jobs and not add them to the batch:

good_job/app/models/good_job/batch.rb

Lines 119 to 131 in ae74482

	def add(active_jobs = nil, &block)
	record.save if record.new_record?
	buffer = Bulk::Buffer.new
	buffer.add(active_jobs)
	buffer.capture(&block) if block
	self.class.within_thread(batch_id: id) do
	buffer.enqueue
	end
	buffer.active_jobs
	end