Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeTagRegExp not ES5 and IE11 compatible #2479

Closed
Shel-M opened this issue Apr 12, 2024 · 2 comments
Closed

makeTagRegExp not ES5 and IE11 compatible #2479

Shel-M opened this issue Apr 12, 2024 · 2 comments

Comments

@Shel-M
Copy link

Shel-M commented Apr 12, 2024

Utility function makeTagRegExp(tag, global = false) is not valid ES5.

Function utilizes default parameters and template literals, both of which are invalid in IE11 and throw console errors on Edge in IE mode on script load.

Under certain scenarios with embedded browser windows in older applications (a daily unfortunate use for my org), this type of error causes a full pop up error message.

image

@Telroshan
Copy link
Collaborator

Hey, fixed IE 11 incompatibilies in 1.9.12, it should work properly now.
Let me know!

@Shel-M
Copy link
Author

Shel-M commented May 14, 2024

That release seems to have fixed it! Thanks much!

@Shel-M Shel-M closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants