-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on macOS with Apple Silicon #178
Comments
That's strange, mpv should parse the strings correctly if using the linux version of the instructions (that means replacing the characters Though this way is also equivalent and more clean, and should work on Windows, macOS and Linux, but requires the user to edit two files instead of just one. I think we can change the instructions for this in the next release, thanks for the suggestions. |
Are the shaders going to be optimised for apple silicon anytime soon? Or does that depend on the video player? The fast preset works fine when I use it standalone but there are a lot of frame drops when I use it with SVP. |
I don't think it is possible to optimize shaders specifically for any hardware as OpenGL handles all the abstractions and is not very flexible. If the video player can support loading arbitrary external libraries we can move forward to writing optimized code for specialized ML inference processors such as the Apple Neural Engine. Edit: Using SVP can double, triple or quadruple the framerate of a video, which will make the shaders 2x, 3x and 4x, slower respectively if used after SVP. I'm not sure if reversing the order of shader/SVP would improve performance (eg. apply shaders then SVP vs applying SVP then shaders), but it might be worth a try if it is possible. |
Did you find a way to make these shaders work with Apple Silicon in an optimised way that fully uses Metal ? |
Fortunately I was able to follow this guide (https://atlassc.net/2022/01/05/anime4k-on-m1-max/) and got it to work. The article OP only specifies a single profile but I went ahead and made the equivalent profiles for the modes in the Windows and Linux instructions, as seen below. Feel free to add them to a macOS install guide.
The text was updated successfully, but these errors were encountered: