Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt binaries failing for Node 22 on Windows #33

Closed
paulrutter opened this issue Apr 25, 2024 · 9 comments
Closed

Prebuilt binaries failing for Node 22 on Windows #33

paulrutter opened this issue Apr 25, 2024 · 9 comments

Comments

@paulrutter
Copy link
Contributor

See https://github.com/blueconic/node-oom-heapdump/actions/runs/8830424770

@spmiller when you have time, could you check why node 22 doesn't work?

@paulrutter paulrutter changed the title Prebuilt binaries failing for Node 22 Prebuilt binaries failing for Node 22 on Windows Apr 25, 2024
@spmiller
Copy link
Contributor

Hi @paulrutter , I'm away on holiday this week but should be able to take a look first thing next week. It looks like the Windows build can't find npm?!

@paulrutter
Copy link
Contributor Author

paulrutter commented Apr 25, 2024

Great! No hurry.
Yes, somehow npm cannot be found with 22.x

@spmiller
Copy link
Contributor

spmiller commented May 2, 2024

Hi @paulrutter, it's lucky that "first thing next week" turned into Thursday because there is an upstream issue that has had some patches pushed recently:
nodejs/node#52682

By the time you read this they may have cut a new NodeJS release, but I would suggest that we can't build with Node 22 on Windows until the linked issue is resolved.

Good thing Node 22 isn't LTS eh!

@paulrutter
Copy link
Contributor Author

Then we can wait for that to be merged!

@paulrutter
Copy link
Contributor Author

22.1 seems to have fixed it :) thanks for checking it out @spmiller

See e36551d

@paulrutter
Copy link
Contributor Author

paulrutter commented May 2, 2024

A compilation failure now, i can look into this

@paulrutter paulrutter reopened this May 2, 2024
@paulrutter
Copy link
Contributor Author

nodejs/nan#968

@paulrutter
Copy link
Contributor Author

https://github.com/blueconic/node-oom-heapdump/actions/runs/9102048245

paulrutter added a commit that referenced this issue May 16, 2024
@paulrutter
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants