Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag for disabling rendering #363

Open
cafkafk opened this issue Aug 19, 2023 · 4 comments
Open

Flag for disabling rendering #363

cafkafk opened this issue Aug 19, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@cafkafk
Copy link

cafkafk commented Aug 19, 2023

Is your feature request related to a problem? Please describe.
Over at https://github.com/eza-community/eza we would like to use vhs to do integration testing.

This is possible, but a problem we face is we're not aware of any way to disable generating gif's. We'd like to ideally have a flag that would disable gif generation entirely because:

  • It slows down integration tests.
  • It simply isn't necessary when we only use Output <something>.txt.

See eza-community/eza#147 for details on usecase.

Describe the solution you'd like
Ideally, a flag for disabling generating and rendering a gif would be sufficient.

This has the advantage of being non-intrusive and breaking to most users, and allowing us to script an option into our build script to include that flag.

Describe alternatives you've considered
Another alternative would be to use a flag that takes a value, which would perhaps be a better solution for scripting like we are doing. But, as a user of this program, I'm not sure it's what I'd prefer UX wise, and I'd rather leave the extra effort to people writing scripts.

Additional context
If there is no one interested in making this, and a potential solution is just adding an option and a if statement somewhere, I could potentially create a PR for this. But I'm stretched a bit thin, and I've never really had a go at go, so I'd prefer not to.

I am aware of the github actions, but we'd really like to do it this way (while also using the github actions, probably).

Also, if there is another, easier and/or obvious way to do this, please let me know :p

@cafkafk cafkafk added the enhancement New feature or request label Aug 19, 2023
@cafkafk cafkafk changed the title Flag for disabling gif rendering Flag for disabling rendering Aug 19, 2023
@drupol
Copy link

drupol commented Nov 5, 2023

This would be also useful for #109

@maaslalani
Copy link
Member

Awesome! Thanks for considering using VHS for integration testing. Let me see if I can quickly disable GIF generation for situations when an output is set to text.

@cafkafk
Copy link
Author

cafkafk commented Nov 27, 2023

Awesome! Thanks for considering using VHS for integration testing. Let me see if I can quickly disable GIF generation for situations when an output is set to text.

for eza's use case at least, we've moved pretty far past this solution at this point, so we don't really need it anymore

@drupol
Copy link

drupol commented Nov 27, 2023

I would definitely use that new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants