You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The README indicates both that multiple outputs are supported and that there are both .txt and .ascii formats (among others). In the interest of comparing between the two to see if there were any differences, I tried creating a file that listed outputs for both, ie something like:
Output 'test.ascii'
Output 'test.txt'
...
When running, I had expected both to be emitted, but only the first one is and there is not context/output about the second. Looking at the code it seems they both map to the same option here:
I'm not sure why in practice you would actually want to do this (outside of my contrived case), but I still think it would be nice to document this more clearly and/or provide some kind of feedback or output when you do this (rather than silently failing as it presently does). It might also be nice to document the .test file format, which the code shows but that is not mentioned by the README (it appears to match the format of the .txt version).
Also, I can see that there are some differences between the ascii and test/txt versions. Is there somewhere I could see more information about expectations/format for the goldenfiles so I can decide which format to use? And do either of these match the formatting of charmbracelet/x/teatest goldenfiles? Any more info/details would be appreciated as I went searching through the code some myself and didn't have much luck in growing my understanding.
Thanks!
The text was updated successfully, but these errors were encountered:
Describe the bug
The README indicates both that multiple outputs are supported and that there are both
.txt
and.ascii
formats (among others). In the interest of comparing between the two to see if there were any differences, I tried creating a file that listed outputs for both, ie something like:When running, I had expected both to be emitted, but only the first one is and there is not context/output about the second. Looking at the code it seems they both map to the same option here:
vhs/command.go
Line 291 in 7dd24a2
I'm not sure why in practice you would actually want to do this (outside of my contrived case), but I still think it would be nice to document this more clearly and/or provide some kind of feedback or output when you do this (rather than silently failing as it presently does). It might also be nice to document the .test file format, which the code shows but that is not mentioned by the README (it appears to match the format of the .txt version).
Also, I can see that there are some differences between the ascii and test/txt versions. Is there somewhere I could see more information about expectations/format for the goldenfiles so I can decide which format to use? And do either of these match the formatting of charmbracelet/x/teatest goldenfiles? Any more info/details would be appreciated as I went searching through the code some myself and didn't have much luck in growing my understanding.
Thanks!
The text was updated successfully, but these errors were encountered: