Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom sendButton icon #122

Open
WillSmithTE opened this issue Jul 24, 2023 · 4 comments
Open

Custom sendButton icon #122

WillSmithTE opened this issue Jul 24, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@WillSmithTE
Copy link

Great library, thanks for maintaining it.

Would you consider allowing for a custom SendButton icon passed as a prop?

@supersnager supersnager self-assigned this Sep 27, 2023
@andreisocaciu
Copy link

Any news on this feature? 😀

@supersnager supersnager added the enhancement New feature or request label Mar 4, 2024
@supersnager
Copy link
Contributor

@WillSmithTE Please explain what exactly you want to achieve?
Do you want to add an "icon" property to the <SendButton /> component, or pass custom send icon to the <MessageInput /> component?

@WillSmithTE
Copy link
Author

I believe it would have to be on the MessageInput, because that uses the SendButton directly. Unless you wanted to open up a sendButtonProps on the MessageInput, and then add the icon property to the SendButton.

I don't mind how the implementation is, but the idea is to change the icon from <FontAwesomeIcon icon={faPaperPlane} /> to whatever we want.

Probably a more flexible approach is to add a prop for a totally custom SendButton, which is then given the disabled and onClick props by MessageInput.

@supersnager
Copy link
Contributor

@WillSmithTE Thank you for the clarification. At a glance the last option (custom SendButton) is the best, but but I will take a fresh look at it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants