feat: Add options for what to do with missing metadata fields in MetaFieldRanker
#7700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
MetaFieldRanker
: allow different options for what to do with missing metadata field #7691missing_meta
toMetaFieldRanker
:Proposed Changes:
missing_meta
param has three options:"bottom"
,"top"
, and"drop"
."bottom"
exhibits the same behavior as was implemented prior to this PR, i.e., documents without the sorting metadata field are put on the bottom of the sorted list."top"
puts them at the top instead."drop"
drops such documents entirely.missing_meta
is legit.How did you test it?
Wrote and tried new tests functions in the
test
directory:test_raises_value_error_if_wrong_missing_meta
: Tests validation ofmissing_meta
test_missing_meta_bottom
: Tests thatmissing_meta = "bottom"
behaves as desired.test_missing_meta_top
: Tests thatmissing_meta = "top"
behaves as desired.test_missing_meta_drop
: Tests thatmissing_meta = "drop"
behaves as desired.Notes for the reviewer
None
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.