Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NODE_DEBUG env var should be handled internally #23687

Closed
bartlomieju opened this issue May 3, 2024 · 0 comments · Fixed by #23694
Closed

NODE_DEBUG env var should be handled internally #23687

bartlomieju opened this issue May 3, 2024 · 0 comments · Fixed by #23694
Assignees
@satyarohith
Labels
bug Something isn't working

Comments

@bartlomieju
Copy link
Member

This PR #23583 introduced a problem that env vars are read on startup (during the runtime creation). This is not great, because some embedders, might not provide API to read env vars or haven't captured env vars yet.

We need to read this env var explicitly during intialization (or accept it as a parameter for worker creation) and not rely on Deno.env.get API.
@bartlomieju bartlomieju added the bug Something isn't working label May 3, 2024
@satyarohith satyarohith mentioned this issue May 4, 2024
Merged
satyarohith added a commit that referenced this issue May 5, 2024
@satyarohith
fix(ext/node): don't rely on Deno.env to read NODE_DEBUG (#23694)
b2628e4 
This patch allows implementors to use ext/node without
the need to implement Deno.env API.

Closes #23687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satyarohith satyarohith

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/node): don't rely on Deno.env to read NODE_DEBUG satyarohith/deno
2 participants
@bartlomieju @satyarohith