Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #201 broke some examples in the English README.md file #204

Open
NeeEoo opened this issue Mar 26, 2021 · 1 comment
Open

Pull request #201 broke some examples in the English README.md file #204

NeeEoo opened this issue Mar 26, 2021 · 1 comment

Comments

@NeeEoo
Copy link

NeeEoo commented Mar 26, 2021

In example "Adding arrays", the code in the example doesn't work.
In example "Addition of RegExps", the code was formatted weirdly causing it not to return the correct result. The original was /7/ - /5/;
In example "Double dot", the code was changed from 27..toString() to (27).toString(); in both the explanation and example.
In example "Why you should use semicolons", the code from the explanation was copied into the example.

I think that example "Extra Newness" is broken.
I also think that example "A generator which yields itself" is broken.

@NeeEoo
Copy link
Author

NeeEoo commented Mar 26, 2021

It also seems that some examples in the other translations are broken. For example Korean, Italian, Hindi and maybe more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant