Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis-py doesn't throw NoPermissionError on ACL mismatch #3047

Closed
safa-topal opened this issue May 14, 2024 · 1 comment · Fixed by #3049
Closed

redis-py doesn't throw NoPermissionError on ACL mismatch #3047

safa-topal opened this issue May 14, 2024 · 1 comment · Fixed by #3049
Assignees
@kostasrim
Labels
bug Something isn't working

Comments

@safa-topal
Copy link

Describe the bug
When a Dragonfly ACL is violated with redis-py library, it does not throw NoPermissionError but instead throws ResponseError with message starting with NOPERM:.

To Reproduce
Steps to reproduce the behavior:

  1. Violate an ACL with redis-py library
  2. See that it throws ResponseError with NOPERM:

Expected behavior
redis-py should throw NoPermissionError.

Environment (please complete the following information):

  • Dragonfly Version: 1.16.1
@safa-topal safa-topal added the bug Something isn't working label May 14, 2024
@kostasrim
Copy link
Contributor

Yep, we are sending the wrong error type -- I will fix this :)

@kostasrim kostasrim self-assigned this May 14, 2024
@kostasrim kostasrim mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostasrim kostasrim

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(acl): return -NOPERM instead of response error dragonflydb/dragonfly
2 participants
@kostasrim @safa-topal