Check for failed shards in count #1444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al/elasticsearch-dsl-py into bugfix/count-with-failed-shards
|
Unfortunately it is difficult to know how to handle shard failures. Automatically raising a failure is not always the correct option, to me it feels the best option would be to expose the information, so that each application can decide if and how many shards failing should be considered a failure. Based on your description in #1302 you are sending queries that are bad, so in that case a returned count of 0 does not seem completely wrong. So I'm going to close this PR, but will keep the issue open, as we need a way to expose the complete results of the count operation for applications that need to make decisions based on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1302 .
When some shards fail, the count is returned as a default or a partial answer, hiding the error from the user.