[System] Mark logs-system.syslog data stream as requires root
#9893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the formatting in the diff is just the result of |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @kpollich |
|
mjwolf
approved these changes
May 16, 2024
ishleenk17
approved these changes
May 16, 2024
|
Package system - 1.58.0 containing this change is available at https://epr.elastic.co/search?package=system |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Mark logs-system.syslog data stream as requires root
Reading syslog files requires root, so if this data stream is in use the agent will require root privileges. Adding
agent.privileges.root: truemakes Fleet/Agent aware of the requirement for escalated privileges.Checklist
changelog.ymlfile.How to test this PR locally
Run an agent with the system integration and verify it collects data when run as a root user. I don't think the majority of the non-root agent work is "wired up" so there won't be anything obvious to test at this time. See elastic/kibana#183283.
Related issues
Closes #9886