Pinging @elastic/kibana-esql (Team:ESQL)

Pinging @elastic/kibana-presentation (Team:Presentation)

Pinging @elastic/kibana-visualizations (Team:Visualizations)

I am moving this to the presentation and visualizations teams, it seems that the panels filters do not listen the changes or something like that.

Confirming here that this is a Presentation team bug. It's likely caused by our embeddable refactor work. I.e. actions don't subscribe to every state change anymore, just the ones that are likely to cause them to update.

Should be a pretty straightforward fix.

Thanx Devon and team for your super fast response

@stratoula

I have diagnosed the problem and need help with picking the best solution. The problem is that there are 2 sources of visualization state in the LensEmbeddable, this.savedVis and input.attributes.

FiltersNotificationPopover is reading the query from api.query$?.value, where api is the LensEmbeddable instance.

LensEmbeddable.query$ gets updated when input changes and the new value is pulled from query$.next(embeddable.getQuery());

if (isFilterableEmbeddable(embeddable)) {
    embeddable.untilInitializationFinished().then(() => {
      filters$.next(embeddable.getFilters());
      query$.next(embeddable.getQuery());

      subscriptions.add(
        embeddable.getInput$().subscribe(() => {
          if (
            !compareFilters(
              embeddable.filters$.getValue() ?? [],
              embeddable.getFilters(),
              COMPARE_ALL_OPTIONS
            )
          ) {
            filters$.next(embeddable.getFilters());
          }
          if (!deepEqual(embeddable.query$.getValue() ?? [], embeddable.getQuery())) {
            query$.next(embeddable.getQuery());
          }
        })
      );
    });
  }

The LensEmbeddable implementation of getQuery pulls the query from this.savedVis?.state.query

  public getQuery() {
    return this.savedVis?.state.query;
  }

The problem is that this.savedVis is not updated when a users clicks run in the ESQL editor. Instead, the new visualization is stored like this.updateInput({ attributes: newViz })

async updateSuggestion(attrs: LensSavedObjectAttributes) {
    const viz = this.savedVis;
    const newViz = {
      ...viz,
      ...attrs,
    };
    this.updateInput({ attributes: newViz });
  }

What is the best solution to this problem? Should this.savedVis be updated when inline editing occurs? Should LensEmbeddable.getQuery be updated to read from input.attributes instead of this.savedVis?

Please advise.

Thanx for digging into this Nathan, I see. I think the cleanest solution is that the LensEmbeddable.getQuery should read from the input instead of the savedVis