Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lens] ES|QL editor shows canceled statement #183651

Open
nreese opened this issue May 16, 2024 · 2 comments
Open

[lens] ES|QL editor shows canceled statement #183651

nreese opened this issue May 16, 2024 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.14.0
Projects
Lens

Comments

@nreese
Copy link
Contributor

nreese commented May 16, 2024

Test steps

  1. install sample web logs
  2. create new dashboard.
  3. Set time range to last 24 hours
  4. Add ESQL panel by clicking "Add panel" -> "ES|QL" -> "Apply and close"
  5. Save dashboard
  6. Open context menu and click "Edit ES|QL visualization"
  7. Change ES|QL statement from from logs* | limit 10 to from logs* | limit 1
  8. Click "Cancel" in ES|QL edit flyout.
  9. Save dashboard and reopen dashboard
  10. Open context menu and click "Edit ES|QL visualization". Notice how the ES|QL statement is still from logs* | limit 1 even though the panel is displaying results from the ES|QL statement from logs* | limit 10
@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Feature:ES|QL v8.14.0 labels May 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibanamachine kibanamachine added this to Long-term goals in Lens May 16, 2024
@nreese
Copy link
Contributor Author

nreese commented May 16, 2024

Kind of related to #183561.

The lens embeddable is storing visualization state in multiple places, including this.savedVis and this.input.attributes. Something is not getting cleaned properly on cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.14.0
Projects
No open projects
Lens
  
Long-term goals
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nreese @elasticmachine