Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: window.open with windowname does not work correctly #37949

Closed
3 tasks done
t57ser opened this issue Apr 12, 2023 · 10 comments
Closed
3 tasks done

[Bug]: window.open with windowname does not work correctly #37949

t57ser opened this issue Apr 12, 2023 · 10 comments

Comments

@t57ser
Copy link
Contributor

t57ser commented Apr 12, 2023

Preflight Checklist

Electron Version

23.2.1

What operating system are you using?

Windows

Operating System Version

10.0.19042

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

when a page opens a window with a frame name and afterwards a cross-domain navigation happens and a new window with the same frame name is opened then this should result in 2 distinct windows
Each domain should have its own "context" of window names (chrome behavior)
Additionally, window.open with names is not seperated by partition

Actual Behavior

No new window is opened for different domains

Testcase Gist URL

No response

Additional Information

No response

@pushkin-
Copy link

pushkin- commented Apr 14, 2023

weird, that behavior isn't intuitive to me. If you're using the same window name, why doesn't the same window get navigated. I can repro your behavior even when not navigating to a different domain. In my case, I'm seeing the window.name not to get set to the name I passed in: window.open("https://google.com", "a") (in Chrome)

@t57ser
Copy link
Contributor Author

t57ser commented Apr 14, 2023

@pushkin-
Google is not a good use case, it has a COOP header set that does not allow a child window to be used. You will also see that after creation the window has the closed property set to true.

every window should have its own "context" in regards to window names. otherwise it can happen that you have multiple websites using the same window. even in case of same domain, chrome will open new windows, which makes sense otherwise you would get weird behavior if you have the same website open twice.
Regarding cross-domain, that is an obvious security issue

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jul 14, 2023
@gpetrov
Copy link

gpetrov commented Jul 14, 2023

Bump

@github-actions github-actions bot removed the stale label Jul 15, 2023
@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@t57ser
Copy link
Contributor Author

t57ser commented Oct 18, 2023

bump

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@t57ser
Copy link
Contributor Author

t57ser commented Jan 17, 2024

bump

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@electron-issue-triage
Copy link

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@electron-issue-triage electron-issue-triage bot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants