[Bug]: fs.readdir does not work correctly with files that contain umlauts

[oliverschwendener]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

31.0.0-alpha.3

What operating system are you using?

Windows

Operating System Version

Windows 11

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

I'm trying to read files from a directory using node's fs.readdir function. When there is a file with umlauts in the name, for example äöü.txt it should return 'äöü.txt'.

Actual Behavior

When using fs.readdir in an electron application it returns 'äöü.txt'. Invoking the same code from node (v20.12.2) works as expected.

Testcase Gist URL

https://github.com/oliverschwendener/nodejs-readdir-test

Additional Information

The provided GitHub repo has a guide on how to reproduce the issue.

[codebytere]

Can't reproduce this locally:

nodejs-readdir-test on git:main ❯ e node node.js                               1:50PM
Running "/Users/codebytere/Developer/electron-gn/src/out/Testing/Electron.app/Contents/MacOS/Electron node.js"
{ node: '20.12.2' }
[
  'äöü.txt'
]

[oliverschwendener]

As far as I understand, it happens only on Windows.

[codebytere]

@oliverschwendener you're right - my bad! reproduced on windows - will investigate further. Interestingly, this doesn't happen in the main process. Running:

const { readdir } = require("fs");
const { homedir } = require("os");
const { join } = require("path");

console.log({ node: process.versions.node });

readdir(join(homedir(), "Desktop"), (error, files) => {
    if (error) {
        console.error(`error: ${error}`);
    } else {
        console.log(files);
    }
});

in main.js correctly produces:

Saving files to temp directory...
Saved files to C:\Users\CODEBY~1\AppData\Local\Temp\electron-fiddle-9588-F6KBkUwJ7Ziu
Electron v999999999.9.9 started.

{ node: '20.12.2' }
[
'test.pdf',
'win_notif.patch',
'äöü.txt'
]

Electron exited with signal SIGTERM.

[oliverschwendener]

Interesting. With Electron Fiddle it works as expected, but when I run it with electron (in the main process) it does not work.