Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newArchEnabled=true not working on android #44550

Open
Yoon-SeungHwan opened this issue May 13, 2024 · 2 comments
Open

newArchEnabled=true not working on android #44550

Yoon-SeungHwan opened this issue May 13, 2024 · 2 comments
Labels
Needs: Attention Issues where the author has responded to feedback. Needs: Triage 🔍 Platform: Android Android applications. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)

Comments

@Yoon-SeungHwan
Copy link

Yoon-SeungHwan commented May 13, 2024

Description

I'm trying integration RN onto existing android app based on guide

after finish every steps, I did set newArchEnabled=true in gradle.properties

however it looks not working when the app access to metro bundle I can see

Running "MyAppName" with {"rootTag":11}

without the flag. fabric: true

Steps to reproduce

  1. create RN project
  2. paste existing android project under RN project
  3. set newArchEnabled=true
  4. build and run on device

React Native Version

0.74.1

Affected Platforms

Runtime - Android

Areas

Fabric - The New Renderer, Codegen

Output of npx react-native info

System:
  OS: macOS 13.6
  CPU: (10) arm64 Apple M1 Pro
  Memory: 79.95 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.12.0
    path: ~/.nvm/versions/node/v20.12.0/bin/node
  Yarn:
    version: 3.6.4
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.5.0
    path: ~/.nvm/versions/node/v20.12.0/bin/npm
  Watchman:
    version: 2024.05.06.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/dylan/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK:
    API Levels:
      - "28"
      - "32"
      - "33"
      - "34"
    Build Tools:
      - 28.0.3
      - 30.0.3
      - 32.0.0
      - 33.0.0
      - 33.0.1
      - 34.0.0
    System Images:
      - android-33 | Google APIs ARM 64 v8a
    Android NDK: 22.1.7171670
IDEs:
  Android Studio: 2023.2 AI-232.10300.40.2321.11567975
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.11
    path: /Users/dylan/.jenv/shims/javac
  Ruby:
    version: 3.3.0
    path: /Users/dylan/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.1
    wanted: 0.74.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: false

Stacktrace or Logs

nothing

Reproducer

Repository

Screenshots and Videos

No response

@Yoon-SeungHwan Yoon-SeungHwan added Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) labels May 13, 2024
@github-actions github-actions bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Platform: Android Android applications. labels May 13, 2024
@cortinico
Copy link
Contributor

We can't help you further without any more information.
We'll need to see the code somehow of your application

@github-actions github-actions bot removed the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label May 21, 2024
@Yoon-SeungHwan
Copy link
Author

Yoon-SeungHwan commented May 21, 2024

We can't help you further without any more information. We'll need to see the code somehow of your application

I put repository url for reproducer @cortinico

what i did is, create react-native project, create new android to replacement android inside of RN project
follow https://reactnative.dev/docs/integration-with-existing-apps?language=kotlin
and add below properties into gradle.properties

hermesEnabled=true
newArchEnabled=true

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention Issues where the author has responded to feedback. Needs: Triage 🔍 Platform: Android Android applications. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Development

No branches or pull requests

2 participants