Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] flytectl demo start fails with "Error: malformed version" #5379

Open
2 tasks done
davidmirror-ops opened this issue May 16, 2024 · 2 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working flytectl Issues related to flytectl -Flytes CLI monorepo

Comments

@davidmirror-ops
Copy link
Contributor

Describe the bug

An attempt to create a demo cluster using:

flytectl demo start

fails with:

πŸ§‘β€πŸ­ Bootstrapping a brand new Flyte cluster... πŸ”¨ πŸ”§
Error: Malformed version: flytectl/v0.8.20

flytectl version: 0.8.15

Once I upgraded using my OS package manager, it worked:

brew upgrade flytectl
==> Upgrading flyteorg/tap/flytectl
  0.8.15 -> 0.8.20
flytectl demo start
πŸ§‘β€πŸ­ Bootstrapping a brand new Flyte cluster... πŸ”¨ πŸ”§
πŸ‹ Going to use Flyte v1.12.0 release with image cr.flyte.org/flyteorg/flyte-sandbox-bundled:sha-bd3ed0d2684bddbc8fad1c26d4bc39a86e91077f
πŸ‹ Pulling image cr.flyte.org/flyteorg/flyte-sandbox-bundled:sha-bd3ed0d2684bddbc8fad1c26d4bc39a86e91077f
sha-bd3ed0d2684bddbc8fad1c26d4bc39a86e91077f: Pulling from flyteorg/flyte-sandbox-bundled
a979e9cd3052: Already exists
f6a97a38429d: Already exists
df4226345ac8: Pull complete
....

Some users, already running 0.8.20 had to use a different workaround:

flytectl demo start --version v1.12.0

This seems to be related to a reference all pre 0.18.0 flytectl versions had to the -now archived- repo: https://github.com/flyteorg/flytectl/blob/c7123189f6dfc69af36167f126bf4ae4b14e2894/pkg/github/githubutil.go#L30

Further investigation is needed.

Expected behavior

flytectl demo start should work without issues nor having to upgrade the client.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@davidmirror-ops davidmirror-ops added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels May 16, 2024
@davidmirror-ops davidmirror-ops removed the untriaged This issues has not yet been looked at by the Maintainers label May 16, 2024
Copy link

runllm bot commented May 16, 2024

The issue you're experiencing with flytectl demo start failing due to a "Malformed version" error is likely related to changes in the Flyte repository structure. Upgrading flytectl to the latest version (0.8.20) resolves the issue for most users. Alternatively, specifying the Flyte version explicitly using --version v1.12.0 can also serve as a workaround.

Would you like more details on how to upgrade flytectl or specify the version explicitly?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a πŸ‘ if this is helpful and πŸ‘Ž if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@eapolinario
Copy link
Contributor

The flytectl demo start command checks for the available Flyte releases, unfortunately, versions of flytectl prior to v0.8.20 do not filter out releases named with a prefix (e.g. flytectl/v0.8.20), which ends up causing an error which prevents the sandbox from starting.

This only affects the command if neither --image nor --version are used. From the help:

❯ flytectl demo start --help | grep -E "(--image |--version)" | tail -n2
      --image string                           Optional. Provide a fully qualified path to a Flyte compliant docker image.
      --version string                         Version of flyte. Only supports flyte releases greater than v0.10.0

@eapolinario eapolinario added flytectl Issues related to flytectl -Flytes CLI monorepo labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytectl Issues related to flytectl -Flytes CLI monorepo
Projects
None yet
Development

No branches or pull requests

2 participants