Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow keys pan in the opposite direction to toolbar fourway #196

Open
cjmayo opened this issue Dec 17, 2020 · 3 comments
Open

Arrow keys pan in the opposite direction to toolbar fourway #196

cjmayo opened this issue Dec 17, 2020 · 3 comments

Comments

@cjmayo
Copy link
Collaborator

cjmayo commented Dec 17, 2020

The signs for the x, y values:

def on_key_left(self, state):
self.nudge(-1, 0, state)
def on_key_right(self, state):
self.nudge(1, 0, state)
def on_key_up(self, state):
self.nudge(0, -1, state)
def on_key_down(self, state):
self.nudge(0, 1, state)

are opposite to the fourway:
Left: x is +ve
Up: y is +ve

Maybe I just don't get the concept.

@edyoung
Copy link
Member

edyoung commented Dec 18, 2020

Good point. I think the fourway should be reversed.

@cjmayo
Copy link
Collaborator Author

cjmayo commented Dec 18, 2020

I suppose there are two models: move the point of view (arrow keys), move the object (fourway).

Other examples: a first-person game would move the point of view; a touch screen would move the object. In the first-person game you know that the model is point of view, and their is often some relevant on-screen graphic e.g. a sight.
I don't think we have anything as a concept or a graphic that makes it obvious that it is the point of view that is being controlled.

@edyoung
Copy link
Member

edyoung commented Dec 19, 2020

Either model is defensible, but seems like the 2 ought to be consistent. And to me at least it seems like the way the arrow keys work is more intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants