Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate workflow step names #87

Open
fractaledmind opened this issue Sep 11, 2023 · 0 comments
Open

Handle duplicate workflow step names #87

fractaledmind opened this issue Sep 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@fractaledmind
Copy link
Owner

Imagine having a job like this:

with_acidic_workflow persisting: { } do |workflow|
  workflow.step :no_op, awaits: [PreprocessingJob.new]
  workflow.step :do_thing
  workflow.step :no_op, awaits: :post_process_if_necessary
end

Currently, workflow steps with the same name will conflict and only one will be set in the Run#workflow hash. This is a foot-gun. We don't like foot-guns. We should resolve

@fractaledmind fractaledmind added the bug Something isn't working label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant