not have trino data source in redash frontend

[Leelongqi]

hello, why i install redash:latest not have trino datasource, but in redash:v10 have trino datasource, i need *trino datasource, i install redash serverce according to https://redash.io/help/open-source/dev-guide/docker. why dont have this datasource ? and how can i do? thanks!

[justinclift]

@Leelongqi Sorry for not answering you over the last few days, I've been moving house and getting things set up here.

It's mostly all set up now, so I'll hopefully be able to look at this later on today and figure out what's going on. 😄

[Leelongqi]

I'm sorry to bother you! Thank you very much for taking time out of your busy schedule to answer my questions, you can use docker environment（docker build & docker compose up -d） to build redash service (do not use make compilation), and it is better to give me an installation log, thanks~

[justinclift]

Yeah, I can confirm that a Trino entry isn't present when built from our latest source:

Next step is determining why that is, and fixing it. I'm way too tired to investigate at the moment, so will need to look at it tomorrow.

But yeah, this is definitely not you doing something wrong. If that helps. 😉

[justinclift]

So now we just have to wait for someone else to fix it?

There's a problem with the pygridgain data source code, causing the Trino data source not to be available.

The developers of pygridgain are aware of the problem, and have said they'll take a look at it.

That was 5 days ago, not even a week. Let's give them a few more days.

If they don't fix the problem in a few more days, we can remove the pygridgain data source so that Trino is available. Then we can look into fixing whatever else is going wrong with the Trino data source.

[Leelongqi]

Ok, got it！😉

[Leelongqi]

hi, by the way, are they beginning to fix the problem?😄

[justinclift]

@Leelongqi They've said they'll be starting on it "in the next sprint or two".

Instead of waiting for that, lets remove the pygridgain dependency for now so that Trino at least shows up in the data sources list.

We can work on other Trino problems once that's in place. 😄

[justinclift]

This PR should get the Trino data source to show up: #6546

That 'NoneType' object has no attribute 'test_connection' error will probably still occur though, and will need someone to investigate it.

[justinclift]

@Leelongqi @masayuki038 The redash/redash:preview image on Docker Hub should have Trino as an available data source now.

Would either of you have time to try it out, and let us know if it does really work?

Note that even if the Test Connection button throws an error, the actual data source might still work. So probably best to try both approaches and see what happens. 😄

[justinclift]

Oh. I meant, please show us the output from that command when you run it again.

As a thought, instead of taking screenshots (pictures) you can copy-and-paste the text into a comment, between three "tick" marks. Like this:

```
Stuff goes here
```

The tick marks are for quoting text, so it turns out like this:

Stuff goes here

Also, the output of running docker image ls | grep redash would be useful too. And please run it again, not show the output from a previous run. 😄

[Leelongqi]

Got it, You want more useful information.

redash-email-1       maildev/maildev                            "bin/maildev"                                                                                                   email       2 weeks ago   Up 2 weeks (healthy)   0.0.0.0:1025->1025/tcp, :::1025->1025/tcp, 0.0.0.0:1080->1080/tcp, :::1080->1080/tcp
redash-postgres-1    pgautoupgrade/pgautoupgrade:15-alpine3.8   "/usr/local/bin/docker-entrypoint.sh postgres -c fsync=off -c full_page_writes=off -c synchronous_commit=OFF"   postgres    2 weeks ago   Up 2 weeks             0.0.0.0:15432->5432/tcp, :::15432->5432/tcp
redash-redis-1       redis:7-alpine                             "docker-entrypoint.sh redis-server"                                                                             redis       2 weeks ago   Up 2 weeks             6379/tcp
redash-scheduler-1   redash_scheduler:1.0                       "/app/bin/docker-entrypoint dev_scheduler"                                                                      scheduler   2 weeks ago   Up 2 weeks             5000/tcp
redash-server-1      redash_server:1.0                          "/app/bin/docker-entrypoint dev_server"                                                                         server      2 weeks ago   Up 2 weeks             0.0.0.0:5678->5678/tcp, :::5678->5678/tcp, 0.0.0.0:5001->5000/tcp, :::5001->5000/tcp
redash-worker-1      redash_worker:1.0                          "/app/bin/docker-entrypoint dev_worker"                                                                         worker      2 weeks ago   Up 2 weeks             5000/tcp

[justinclift]

Up 2 weeks

Ok, that means you're still running an old version of the Redash containers.

Please try updating to the very latest development source code, or switch to our latest "preview" docker image (redash/redash:preview) on Docker Hub.

That should fix the problems you're seeing. 😄

[Leelongqi]

ok ~ thanks @justinclift

[Leelongqi]

@justinclift @masayuki038 when i use trino datasource in redash, i find there is no show catalog

• Adding TrinoDB datasource
  

• execute query1 ,

• execute query2
  

I think that it should show catalog, Otherwise, the user does not know the catalog and the query will fail

[justinclift]

Ahhh. I don't personally know anything about Trino, so am not the right person to work on the rest of this.

That being said, is there a standard default Catalog name that we could potentially put in the Catalog field for the data source. Default value type of thing, so it could be changed if needed?

Or is that not the right approach for Trino? 😄

[masayuki038]

@Leelongqi If it got empty schema information at once, the datasource didn't work fine even if I added a new table under the schema.
Could you try creating another datasource (like test2) on the same connection settings?

[Leelongqi]

@masayuki038 Adding a new table results in the same result（got empty schema）

[masayuki038]

@Leelongqi Thanks for your trying...

• Are there any errors in logs?
• Can you query your Trino in this situation?
• Are there any errors in your browser?
  • If you are using Chrome, please launch 'developer tool' and check 'Console'

[Leelongqi]

@masayuki038 sorry, I have been busy with other things recently, may I ask if you have fixed the problem that trino datasource does not display catalog in redash:latest. If you have not fixed the problem, my suggestion is that you first reproduce the problem on your computer and test the tune-up, which will be more efficient

[masayuki038]

@Leelongqi Please don't mind.
Are you using redash/redash:latest? If so, please try redash/redash:preview...