Should we change the setup script to not automatically overwrite the environment file?

[justinclift]

This part of the Redash setup.sh script bothers me: https://github.com/getredash/setup/blob/654f24aa2783fed921979cd3251be3f20740826f/setup.sh#L111-L114

if [ -e "$REDASH_BASE_PATH"/env ]; then
  rm "$REDASH_BASE_PATH"/env
  touch "$REDASH_BASE_PATH"/env
fi

That's automatically deleting any existing environment file when the script runs, which means that anyone who runs it more than once is going to have a mismatch between their environment file and their Redash PostgreSQL database.

It's also a common source of problems for new users.

I'm thinking we should change that to not automatically delete it.

We could also check for the presence of the minimum required fields too, to ensure the existing environment file won't result in a broken setup. Maybe generate any missing values, and let the user know?

For the existing behaviour of deleting any env file that exists, we could probably use a switch (--replace or something) to preserve that behaviour, for anyone who needs it?

What do people think?

[justinclift]

Created a PR to fix the problem: getredash/setup#60

That PR also adds an optional --overwrite argument to the setup.sh script for those who really do want to blow away their existing installation when it runs.

[justinclift]

The Redash setup script now supports several different Linux distributions:

• Alma Linux 8.x & 9.x
• CentOS Stream 9.x
• Debian 12.x
• Oracle Linux 9.x
• Red Hat Enterprise Linux 8.x & 9.x
• Rocky Linux 8.x & 9.x
• Ubuntu LTS 20.04 & 22.04

It'd be nice to support macOS and WSL as well, but that can come at some future point.

Unless someone else wants to implement those sooner, which would be welcome too. 😄