Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Config] Implement /settings/remote-config page within Sentry based on api.md in #70805 #71128

Closed
ryan953 opened this issue May 17, 2024 · 0 comments · Fixed by #71924
Closed

[Remote Config] Implement /settings/remote-config page within Sentry based on api.md in #70805 #71128

ryan953 opened this issue May 17, 2024 · 0 comments · Fixed by #71924
Assignees
@ryan953

Comments

@ryan953
Copy link
Member

ryan953 commented May 17, 2024

https://github.com/getsentry/sentry/pull/70805/files
@ryan953 ryan953 self-assigned this May 17, 2024
@ryan953 ryan953 changed the title Implement /settings/remote-config page within Sentry based on api.md in #70805 [Remote Config] Implement /settings/remote-config page within Sentry based on api.md in #70805 May 17, 2024
@ryan953 ryan953 mentioned this issue Jun 3, 2024
Merged
ryan953 added a commit that referenced this issue Jun 4, 2024
@ryan953 @michellewzhang
feat(remote config): Add a settings page for remote config basics (#7…
989543c 
…1924)

Create a new project settings page for Remote Config options. This is
the first verison of the page, def not the last! We'll be changing the
api that this page talks to, as well as the buttons and layout as we
iterate.

The purpose of this version is to make it possible for people to save
their configs.

<img width="1521" alt="SCR-20240603-hmxz"
src="https://github.com/getsentry/sentry/assets/187460/012f0006-c09e-4820-a827-df13f7d48f46">


Known problems:
- the delete button works to delete the config, but it doesn't render
toasts properly on the screen because the backend is returning a 503 for
some reason.
- you will be prevented from creating two 'features' with the same key,
but the ui doesn't give feedback, needs a "this is a duplicate key"
label to be added.

Fixes #71128

---------

Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan953 ryan953

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(remote config): Add a settings page for remote config basics getsentry/sentry
1 participant
@ryan953