Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A3-1-5: Exclude instantiated templates and compiler generated members #382

Closed
lcartey opened this issue Oct 3, 2023 · 1 comment
Closed

A3-1-5: Exclude instantiated templates and compiler generated members #382

lcartey opened this issue Oct 3, 2023 · 1 comment
Assignees
@knewbury01
Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards

Comments

@lcartey
Copy link
Collaborator

lcartey commented Oct 3, 2023 •
edited

Affected rules

  • A3-1-5

Description

Exclude instantiated templates from this rule here:
https://github.com/github/codeql-coding-standards/blob/main/cpp/common/src/codingstandards/cpp/Class.qll#L184

Also exclude compiler generated members.

Example
@lcartey lcartey added Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards labels Oct 3, 2023
@lcartey lcartey changed the title A3-1-5: Exclude instantiated templates A3-1-5: Exclude instantiated templates and compiler generated members Nov 20, 2023
@knewbury01 knewbury01 self-assigned this Jan 23, 2024
@knewbury01
Copy link
Contributor

knewbury01 commented Jan 31, 2024 •
edited

there is no example, so it is a bit unclear what the goal is - based on the cited library location already specifying member functions that are not involved in instantiated templates

however, when looking at this rule perhaps this issue had something to do with this part of the rule not being constrained to avoid template instantiations here

all in all, I think the rule logic needs more work though and that/any feedback this issue was describing will be captured in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knewbury01 knewbury01

Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards
Projects
Coding Standards Public Development Board
Status: Closed (Duplicate)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lcartey @knewbury01