-
Notifications
You must be signed in to change notification settings - Fork 58.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added instruction for ignoring the Gemfile.lock file to prevent unsatisfiable dependencies warning in the creating-a-github-pages-site-with-jekyll page #32352
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@revolter Thanks so much for opening a PR! I'll get this triaged for review ✨ |
…isfiable dependencies warning in the creating-a-github-pages-site-with-jekyll page
I think that the failing lint job is not actually caused by this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for raising this pull request and also the issue where you described the problem. Your clear explanation made this much easier to review.
I'm going to approve this and we can merge it. Apologies for the delay in reviewing.
Actually - first I need to ask our engineering team to take a look at your changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the contribution, @revolter ❤️
Line 2 in 0beff02
# For languages that support highlighting: https://github.com/highlightjs/highlight.js/blob/main/SUPPORTED_LANGUAGES.md |
gitignore
isn't a supported language for highlighting per the supported languages for highlight.js, so I just removed that. Otherwise we're good to merge.
@hectorsector, thank you very much for explaining your commit! ❤️ I was already thinking of asking you, to understand the reasoning 🙈 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why: Warning prevention
Closes: #32351
What's being changed (if available, include any code snippets, screenshots, or gifs):
Gemfile.lock
file, and this PR fixes thisCheck off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.