-
Notifications
You must be signed in to change notification settings - Fork 58.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact attestation needs id-token: write
permission in publishing-docker-images.md
#32926
Conversation
…-docker-images.md Following the current version of the documentation (without the `id-token: write` permission) I am getting the following error message in the `attest-build-provenance` step: `Failed to get ID token: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable` [the documentation of attest-build-provenance](https://docs.github.com/en/actions/security-guides/using-artifact-attestations-to-establish-provenance-for-builds#generating-build-provenance-for-container-images) mentions that we also need the `id-token: write` permission. Therefore, I suggest to add that to the documentation here
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
id-token: write
permission in publishing…id-token: write
permission in publishing-docker-images.md
@thawn Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching and updating this, @thawn! ✨ I'll go ahead and get it merged.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Following the current version of the documentation (without the
id-token: write
permission) I am getting the following error message in theattest-build-provenance
step:Failed to get ID token: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable
the documentation of attest-build-provenance mentions that we also need the
id-token: write
permission.Therefore, I suggest to add that to the documentation for publishing-docker-images.md
Closes:
#32933
What's being changed (if available, include any code snippets, screenshots, or gifs):
added
id-token: write
to thepermissions:
section of the example yml files.id-token: write
to thepermissions:
section of the example yml codeid-token: write
to thepermissions:
section of the example yml codeCheck off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.