Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with broken configuration references #496

Open
Tracked by #115
christophenne opened this issue Apr 10, 2024 · 1 comment
Open
Tracked by #115

Dealing with broken configuration references #496

christophenne opened this issue Apr 10, 2024 · 1 comment
Assignees
Milestone

Comments

@christophenne
Copy link
Member

christophenne commented Apr 10, 2024

Is your feature request related to a problem? Please describe.
A user can enter different kinds of references to choose config values for a package (e.g. ConfigMap, Secret, Package Config), both on the UI and CLI. They don't yet see whether the entered reference (e.g. namespace + name + key in the case of a ConfigMap) can be resolved and is valid (at least on the UI).

Describe the solution you'd like
For a reference input, the user should see some hint of whether the entered reference is:

  • existing and passes validation
  • existing but does not pass validation
  • not existing

To be discussed: This kind of hint should probably not be a strict validation? As also described in #495, when a referenced object gets changed or deleted, the configuration could become invalid. We need a way to deal with this.

There are lots of ways in which a reference could become invalid:

  • a referred value changes, and the new value is not valid according to the glasskube package anymore
  • a referred value is deleted (e.g. because the ConfigMap, Secret or Package has been removed)

Describe alternatives you've considered

Additional context
Follow-Up of #121
Related to #495

@kosmoz
Copy link
Member

kosmoz commented Apr 11, 2024

Notably, the operator already deals with this by not touching any dependent resources and setting a failed condition on the Package resource. This ticket is only about how to handle this situation on the UI (and to a lesser extend CLI).

@kosmoz kosmoz added this to the v0.3.x milestone Apr 22, 2024
christophenne added a commit that referenced this issue May 21, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
@christophenne christophenne self-assigned this May 22, 2024
christophenne added a commit that referenced this issue May 22, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
christophenne added a commit that referenced this issue May 22, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
christophenne added a commit that referenced this issue May 22, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
christophenne added a commit that referenced this issue May 22, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
christophenne added a commit that referenced this issue May 22, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
christophenne added a commit that referenced this issue May 23, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
christophenne added a commit that referenced this issue May 23, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
kosmoz pushed a commit that referenced this issue May 23, 2024
Signed-off-by: christoph <christoph.enne@glasskube.eu>
@pmig pmig modified the milestones: v0.4.x, v0.5.0 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants