Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a different button state if a package is currently being uninstalled #456

Closed
kosmoz opened this issue Apr 2, 2024 · 2 comments · Fixed by #649
Closed

Show a different button state if a package is currently being uninstalled #456

kosmoz opened this issue Apr 2, 2024 · 2 comments · Fixed by #649
Assignees
Labels
component: ui enhancement New feature or request help wanted Extra attention is needed

Comments

@kosmoz
Copy link
Member

kosmoz commented Apr 2, 2024

Currently, a package is displayed as "pending" after starting an uninstall action, provided that the package-operator is running in the cluster. If no package-operator is running, the displayed state doesn't change until the package is finally removed after GC has completed (we use foreground deletion for Glasskube packages).

It would be better to detect if a package has been marked for deletion and display a different button state on the overview and details pages if it is. To start with, the button could look like the "pending" button but with a different text, e.g. "uninstalling". It is important that the button is also disabled.

A resource can be considered marked for deletion if it has a DeletionTimestamp:

if !pkg.DeletionTimestamp.IsZero() {
  // pkg is being deleted ...
}
@Baalekshan
Copy link
Contributor

@kosmoz Can this be worked on now ?

@kosmoz
Copy link
Member Author

kosmoz commented May 6, 2024

Sure, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
2 participants