Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when renaming MP3 file #92061

Closed
KoBeWi opened this issue May 17, 2024 · 3 comments
Closed

Crash when renaming MP3 file #92061

KoBeWi opened this issue May 17, 2024 · 3 comments

Comments

@KoBeWi
Copy link
Member

KoBeWi commented May 17, 2024

Tested versions

4.3 bd2300d
4.3 dev6

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

memcmp() Line 102 (d:\a\_work\1\s\src\vctools\crt\vcruntime\src\string\amd64\memcmp.asm:102)
mp3dec_skip_id3v2(const unsigned char * buf, unsigned __int64 buf_size) Line 165 (c:\godot_source\thirdparty\minimp3\minimp3_ex.h:165)
mp3dec_skip_id3(const unsigned char * * pbuf, unsigned __int64 * pbuf_size) Line 180 (c:\godot_source\thirdparty\minimp3\minimp3_ex.h:180)
mp3dec_iterate_buf(const unsigned char * buf, unsigned __int64 buf_size, int(*)(void *, const unsigned char *, int, int, unsigned __int64, unsigned __int64, mp3dec_frame_info_t *) callback, void * user_data) Line 509 (c:\godot_source\thirdparty\minimp3\minimp3_ex.h:509)
mp3dec_ex_seek(mp3dec_ex_t * dec, unsigned __int64 position) Line 760 (c:\godot_source\thirdparty\minimp3\minimp3_ex.h:760)
AudioStreamPlaybackMP3::seek(double p_time) Line 142 (c:\godot_source\modules\minimp3\audio_stream_mp3.cpp:142)
AudioStreamPlaybackMP3::start(double p_from_pos) Line 111 (c:\godot_source\modules\minimp3\audio_stream_mp3.cpp:111)
EditorAudioStreamPreviewPlugin::generate(const Ref<Resource> & p_from, const Vector2 & p_size, Dictionary & p_metadata) Line 642 (c:\godot_source\editor\plugins\editor_preview_plugins.cpp:642)
EditorResourcePreviewGenerator::generate_from_path(const String & p_path, const Vector2 & p_size, Dictionary & p_metadata) Line 72 (c:\godot_source\editor\editor_resource_preview.cpp:72)
EditorResourcePreview::_generate_preview(Ref<ImageTexture> & r_texture, Ref<ImageTexture> & r_small_texture, const EditorResourcePreview::QueueItem & p_item, const String & cache_base, Dictionary & p_metadata) Line 190 (c:\godot_source\editor\editor_resource_preview.cpp:190)
EditorResourcePreview::_iterate() Line 286 (c:\godot_source\editor\editor_resource_preview.cpp:286)
EditorResourcePreview::_thread() Line 379 (c:\godot_source\editor\editor_resource_preview.cpp:379)
EditorResourcePreview::_thread_func(void * ud) Line 128 (c:\godot_source\editor\editor_resource_preview.cpp:128)
Thread::callback(unsigned __int64 p_caller_id, const Thread::Settings & p_settings, void(*)(void *) p_callback, void * p_userdata) Line 66 (c:\godot_source\core\os\thread.cpp:66)
std::invoke<void (__cdecl*)(unsigned __int64,Thread::Settings const &,void (__cdecl*)(void *),void *),unsigned __int64,Thread::Settings,void (__cdecl*)(void *),void *>(void(*)(unsigned __int64, const Thread::Settings &, void(*)(void *), void *) && _Obj, unsigned __int64 && _Arg1, Thread::Settings && <_Args2_0>, void(*)(void *) && <_Args2_1>, void * && <_Args2_2>) Line 1754 (c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.39.33519\include\type_traits:1754)
std::thread::_Invoke<std::tuple<void (__cdecl*)(unsigned __int64,Thread::Settings const &,void (__cdecl*)(void *),void *),unsigned __int64,Thread::Settings,void (__cdecl*)(void *),void *>,0,1,2,3,4>(void * _RawVals) Line 61 (c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.39.33519\include\thread:61)
thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 (c:\Users\Tomek\AppData\Local\Programs\Microsoft VS Code\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp:97)

Only happens in small projects where filesystem scan is very short.
Might be (indirectly) from #77069, but I didn't test.

Steps to reproduce

  1. Have MP3 in the project
  2. Rename it via FileSystem dock

Minimal reproduction project (MRP)

N/A

@lalitshankarchowdhury
Copy link
Contributor

Tried this on my system with the latest master build bd2300d.

Renaming works as expected on my system.

The file I used.

Could you share the file which is causing errors for you?

@JekSun97
Copy link

JekSun97 commented May 18, 2024

I don't have this problem.

Godot v4.3.dev6 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated Radeon RX 560 Series (Advanced Micro Devices, Inc.; 31.0.14001.45012) - Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 Threads)

@KoBeWi
Copy link
Member Author

KoBeWi commented May 18, 2024

Seems project-specific. I deleted .godot folder and can't reproduce it anymore.

@KoBeWi KoBeWi closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants