You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DistributionIntegrationSpec keeps our distro size in check.
It observes the overall size of the distro ZIPs (all, bin, src and docs), as wella s the number of "core", "plugin" and "third-party" libraries. Updating these numbers is cumbersome, can easily result in conflicts (even hidden ones), and the test is expensive to execute as it needs the whole distro to be built.
Proposed changes:
Drop checking "core" and "plugin" JAR count; we cannot "accidentally" introduce a large amount of code by adding more core or plugin projects.
Either drop the "third-party" JAR count check, too, or make it an assertion in build-logic where we can use the Configuration without having to build the actual distribution
Maybe move the distro size-check to build-logic, too, though we probably do want to have a hard limit on the resulting ZIP size.
Review if we need a list of (some of the) JARs in this test, and if so, make sure that it gets updated.
DistributionIntegrationSpec
keeps our distro size in check.It observes the overall size of the distro ZIPs (
all
,bin
,src
anddocs
), as wella s the number of "core", "plugin" and "third-party" libraries. Updating these numbers is cumbersome, can easily result in conflicts (even hidden ones), and the test is expensive to execute as it needs the whole distro to be built.Proposed changes:
Configuration
without having to build the actual distributiongradle/testing/distributions-integ-tests/src/integTest/groovy/org/gradle/DistributionIntegrationSpec.groovy
Lines 177 to 209 in b1e4b7b
The text was updated successfully, but these errors were encountered: