Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt_locations of createProgramInfo is missing from typescript bindings #231

Open
Deamon87 opened this issue Feb 27, 2024 · 2 comments
Open

Comments

@Deamon87
Copy link

Hi.

As of now there is no possible way to pass opt_locations from typescript for createProgramInfo and other similar functions.

At the moment of writing, createProgramInfo is defined as

export function createProgramInfo(gl: WebGLRenderingContext, shaderSources: string[], opt_attribs?: ProgramOptions | string[] | ErrorCallback, opt_errorCallback?: ErrorCallback): ProgramInfo;

Thus it has 4 parameters: gl, shaderSources, opt_attribs, opt_errorCallback

While in reality, the js function takes 5 parameters: gl, shaderSources, opt_attribs, opt_locations, opt_errorCallback

function createProgramInfo(gl, shaderSources, opt_attribs, opt_locations, opt_errorCallback) {
@greggman
Copy link
Owner

thanks for the bug report. Fixed in v5.5.4 I think

@greggman
Copy link
Owner

b489966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants