-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A way to set the default subtitle per file #4931
Comments
I consider this a bug. The IINA setting For audio/video playback and subtitle rendering support IINA is using a library from the mpv project. The This shows me using Terminal to check what
The
So why is this not working? I believe the issue is that As a workaround we configure IINA to use
To use this
|
Great, thanks for the detailed solution! This seems to have a different effect, however - any subtitles loaded from "outside" of IINA, like a .srt file for example, get forgotten about entirely, meaning that now you don't just have to contend with the wrong subtitle file, you now have to re-import the subtitle file every time you open up the file. I'll play around with the settings a bit more and see if there's something that works even better, or an additional toggle. Hopefully the bug is fixed to make this as intuitive as possible! Edit: Okay, quick solution, should have tested out before posting: If we set the setting value to "all" instead of "fuzzy" that works fine. Just in case this is on my end, I'm putting all my video files and subtitle files in the same folder, with the same name, so this works best for my use case. It's best to play around with these settings, but I feel like "all" is probably good for most use-cases. |
Thanks for reporting your results with the workaround. Frequently defects are coding errors where the code does not function as intended. This is the harder kind of problem, a design problem. IINA loads subtitles "in the background" while starting to play the video. Possibly that was done to address a complaint where playback took a noticeable amount of time to start due to lots of subtitles being loaded? I'm a relatively new IINA developer so I don't know the history and why this choice was made. It has the side effect of breaking the mpv feature for remembering the subtitle that was being used. The second problem you encountered is a problem with the mpv feature itself. As mpv only remembers the index into a list of subtitle streams it will fail if when the file is played again the list of subtitle streams is not exactly the same. If it changes then the index won't point to the correct subtitle. The more restrictive the So the mpv feature is fragile. My guess is that mpv considers this acceptable because a design that does not have this limitation would be significantly more complex. If I get a chance I will add the option to use mpv to find and load subtitles to IINA's settings. Using mpv's feature solves some other issues with IINA's subtitle loading. |
What you want IINA to do:
Simple: When I open up a video file, I want it to automatically use the last subtitle file I chose.
What IINA does currently:
When the video file begins to play, the active subtitle is always the first one in the subtitle panel, ignoring previous choice. This applies to .mkv files with embedded subtitles, at least. Haven't tested it with other filetypes.
(Also: My use case is not wanting to use the embedded subtitles and instead downloading and using my own subtitle file. When doing this, IINA behaves as I describe, not remembering to activate my subtitle file.)
Why you think this should be added:
It's a pretty simple convenience feature, and saves the user from having to go and manually set the subtitles to their preferred video file. Very annoying when resuming movies, for example.
The text was updated successfully, but these errors were encountered: