Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Link to release in footer #4698

Open
shaedrich opened this issue May 14, 2024 · 1 comment · May be fixed by #4702
Open

[Enhancement] Link to release in footer #4698

shaedrich opened this issue May 14, 2024 · 1 comment · May be fixed by #4702
Labels
enhancement Improvement of an existing feature

Comments

@shaedrich
Copy link

Is your enhancement request related to a problem? Please describe.

No.

Describe the solution you'd like
Wrap the SHA/branch text in a link that points to the current release. For example, 2024.04.27-eda7444 @ master would link to https://github.com/iv-org/invidious/releases/tag/v2.20240427 (or just https://github.com/iv-org/invidious/releases/latest)

Describe alternatives you've considered
Leave it as it is.

Additional context
n/a

@shaedrich shaedrich added the enhancement Improvement of an existing feature label May 14, 2024
@Fijxu
Copy link

Fijxu commented May 16, 2024

Something like this should work:

<span>
<% if CONFIG.modified_source_code_url %>
    <%= translate(locale, "Current version: ") %> <a href="<%= CONFIG.modified_source_code_url %>/commit/<%= CURRENT_COMMIT %>"> <%= CURRENT_VERSION %>-<%= CURRENT_COMMIT %> @ <%= CURRENT_BRANCH %> </a>
<% else %>
    <%= translate(locale, "Current version: ") %> <a href="https://github.com/iv-org/invidious/commit/<%= CURRENT_COMMIT %>"> <%= CURRENT_VERSION %>-<%= CURRENT_COMMIT %> @ <%= CURRENT_BRANCH %> </a>
<% end %>
</span>

at https://github.com/iv-org/invidious/blob/master/src/invidious/views/template.ecr#L152

@shaedrich shaedrich linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants